Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More plots for layer errors #1988

Merged
merged 28 commits into from
Nov 5, 2024
Merged

More plots for layer errors #1988

merged 28 commits into from
Nov 5, 2024

Conversation

SamFerracin
Copy link
Collaborator

@SamFerracin SamFerracin commented Oct 21, 2024

This PR adds swarm plotters for LayerErrors.

Preview

newplot (8)
newplot (9)

@SamFerracin SamFerracin marked this pull request as draft October 21, 2024 20:50
@ewinston ewinston self-assigned this Oct 22, 2024
@ihincks
Copy link
Collaborator

ihincks commented Oct 22, 2024

Here is some early feedback without having looked at code.

  1. As always, we need to consider scalability of the plots so they don't crash/burn/look horrible for larger datasets. The bar plots might have some trouble, especially with x ticks, or possibly just looking like a jumble of very thin lines. We should consider plotting only a subset of data and raising a warning.
  2. One scalable alternative/other idea to bar plots consider would be plots of CDFs
  3. I'm on the fence about having separate functions for 1q and 2q weights.

But in general, nice work, and "the more the merrier" for visualization options.

@ihincks
Copy link
Collaborator

ihincks commented Oct 25, 2024

Also for the x labels, I think you can use some subset of simple html tags to do text formatting in plotly. For example, use the <sub> tag for subscripts.

@SamFerracin SamFerracin marked this pull request as ready for review October 31, 2024 19:55
@SamFerracin SamFerracin requested a review from ihincks October 31, 2024 19:55
Copy link
Collaborator

@ihincks ihincks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice.

qiskit_ibm_runtime/visualization/draw_layer_error.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/visualization/draw_layer_error.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/visualization/draw_layer_error.py Outdated Show resolved Hide resolved
@SamFerracin SamFerracin merged commit f9e5f35 into Qiskit:main Nov 5, 2024
19 checks passed
@SamFerracin SamFerracin deleted the more-plots branch November 5, 2024 15:54
@kt474 kt474 added this to the 0.33.0 milestone Nov 5, 2024
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants